search

decidim-archive / decidim-initiatives

:warning: [DEPRECATED] Decidim module for citizen initiatives / e-petitions. Now it's on decidim/decidim repository.
1 stars 2 forks source link

Fix model name #89

Closed oriolgual closed 6 years ago

oriolgual commented 6 years ago

This is a Bug Report

:tophat: Description

In order to follow the naming convention at Decidim the Initiative model should be re-scoped to Decidim::Initiatives::Initiative instead of Decidim::Initiative.

We should also add a migration to rename the database table.

jsperezg commented 6 years ago

IMHO this is not an issue. Check the convention for first level engines: assemblies and participatory processes. All of them live inside Decidim namespace.

josepjaume commented 6 years ago

Hmmm, well this definitely sits on middle ground. While all the plain models from other modules are scoped, it's true that participatory spaces are top-level. And an Initiative is both things at the same time.

Is this blocking you for some reason, @oriolgual ?

oriolgual commented 6 years ago

Not at all, I guess I didn't thought an initiative could be both things. Let's keep it like this then.