decidim-archive / decidim-module-consultations

:warning: [DEPRECATED] Decidim module for consultations: debates around critical questions and a proxy for eVoting. Now it's on decidim/decidim repository.
1 stars 0 forks source link

Reference in questions #31

Closed jsperezg closed 6 years ago

jsperezg commented 6 years ago

This is a Bug Report

:tophat: Description

The mockups show that questions have a reference. The problem with this is that current the HasReference concern only applies to features and a question, since have features itself, is a participatory space.

@xabier @ailopezglez We should disscuss about how important is this feature for the MVP and, in case it's a must find a way to have references in participatory spaces.

xabier commented 6 years ago

Good point! I am not sure this is required from an MVP, but it is certainly important for traceability purposes. I am not sure how to add a hack for this, I don't have the knowledge to evaluate the cost of abstraction for this @decidim/developers any ideas?

@jsperezg leave this out of the MVP for now and we will get back to this when the rest is completed.

mrcasals commented 6 years ago

@jsperezg can you open an issue in the main repo to allow spaces to have a reference?

jsperezg commented 6 years ago

@mrcasals already did it:

https://github.com/decidim/decidim/issues/2527

jsperezg commented 6 years ago

@xabier In order to be ready to deploy this feature ASAP in the future I've added all the required code to the current base code: The reference field exists as well as all visual elements required to show it. As soon as it is implemented in core we will need to change just two files:

version.rb: in order to increase the version number question.rb: Add the HasReference concern to the question model.

xabier commented 6 years ago

@jsperezg well done!

jsperezg commented 6 years ago

https://github.com/decidim/decidim/pull/2557

jsperezg commented 6 years ago

This feature is already implemented but won't be available until Decidim 0.10.

xabier commented 6 years ago

this is perfect! thanks! I close this issue