Closed josepjaume closed 6 years ago
@jsperezg please remember about this PR, it'd be good to merge this ASAP to prevent future blocking.
The issue here is CircleCI
, which doesn't seem to be set up for this repo. After that, we should send a PR to master
and make this compatible with 0.10-pre
.
@josepjaume CircleCI is failing to create the test app
@jsperezg looks like specs are failing
Merging #77 into master will decrease coverage by
27.86%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #77 +/- ##
===========================================
- Coverage 94.83% 66.97% -27.87%
===========================================
Files 65 46 -19
Lines 1239 875 -364
===========================================
- Hits 1175 586 -589
- Misses 64 289 +225
Impacted Files | Coverage Δ | |
---|---|---|
...vices/decidim/consultations/consultation_search.rb | 16.66% <0%> (-83.34%) |
:arrow_down: |
...in/consultation_results_publications_controller.rb | 19.04% <0%> (-71.43%) |
:arrow_down: |
...nds/decidim/consultations/admin/create_question.rb | 42.85% <0%> (-57.15%) |
:arrow_down: |
...decidim/consultations/admin/create_consultation.rb | 45% <0%> (-55%) |
:arrow_down: |
...nds/decidim/consultations/admin/update_question.rb | 45.45% <0%> (-54.55%) |
:arrow_down: |
...ions/abilities/admin/consultation_admin_ability.rb | 47.05% <0%> (-52.95%) |
:arrow_down: |
...decidim/consultations/admin/update_consultation.rb | 47.61% <0%> (-52.39%) |
:arrow_down: |
...im/consultations/abilities/current_user_ability.rb | 50% <0%> (-50%) |
:arrow_down: |
...ecidim/consultations/abilities/everyone_ability.rb | 50% <0%> (-50%) |
:arrow_down: |
...ltations/abilities/admin/question_admin_ability.rb | 53.33% <0%> (-46.67%) |
:arrow_down: |
... and 49 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 00c1e56...f8061f9. Read the comment docs.
:tophat: What? Why?
This syncs this gem's versioning with
decidim
and sets it to the0.9.0
branch.:pushpin: Related Issues
None
:clipboard: Subtasks
None
:camera: Screenshots (optional)
None
:ghost: GIF
None