search

decidim-archive / design

⚠️ [DEPRECATED] Design of the Decidim framework
1 stars 3 forks source link

Intermediate state when adding items to the budget cart #138

Closed josepjaume closed 7 years ago

josepjaume commented 7 years ago

:tophat: User Story

We're disabling the buttons while the request to add a new budget to the cart is being made. This generates a weird padding issue.

Note: We've used a button instead of an a element because it makes more sense semantically and we can then leverage rails' mechanisms to auto-set the disabled property.

:clipboard: Related documentation

:dart: Acceptance criteria

Buttons stay put when clicked.

:pushpin: Related issues

None

htmlboy commented 7 years ago

@josepjaume OK, so I wrote a comment yesterday and apparently I never published. I run some tests and the only thing that can cause this misalignment in decidim-design code is not the disable attribute nor being a button, but the removal of a class: .budget--list__action. So I suspect the same code that is adding the disabled state is removing this class. Could it be? I not, could you send me a staging link to test the origin of the issue?

josepjaume commented 7 years ago

@htmlboy this looks like it got fixed pseudo-accidentally in another PR 👍