decidim-archive / design

⚠️ [DEPRECATED] Design of the Decidim framework
1 stars 3 forks source link

Proposal page aside before content #153

Open lastpotion opened 7 years ago

lastpotion commented 7 years ago

From @beagleknight on June 5, 2017 10:9

This is a Bug Report

:tophat: Description

When I am using a mobile device I see the aside content before the main content:

image

The main content should be visible before the aside content.

:pushpin: Related issues

None

:clipboard: Additional Data

None

Copied from original issue: decidim/decidim#1443

lastpotion commented 7 years ago

From @mrcasals on June 5, 2017 10:32

Shouldn't this be moved to the decidim-design repo?

lastpotion commented 7 years ago

From @beagleknight on June 5, 2017 12:43

Yes, I think @lastpotion is doing it.

lastpotion commented 7 years ago

I was checking this issue, and I found that if we try to reorder the layout to have the aside before content, we needed to change and remove some css classes so that should be moved todecidim-design.

But at the same time, I saw that foundation-rails 6.3.1 gem is adding the following css:

/* line 68, ../../../../.gem/ruby/2.4.1/gems/foundation-rails-6.3.1.0/vendor/assets/scss/grid/_column.scss */
.column:last-child:not(:first-child), .columns:last-child:not(:first-child) {
  float: right;
}

And since decidim-design is builded with a middleman i think is not using this gem, so not sure how I should proceed with this issue and if i thing it belongs to both repos.

@josepjaume @htmlboy any thoughts?

lastpotion commented 7 years ago

From @josepjaume on June 5, 2017 14:3

That must be done by foundation @lastpotion - foundation-rails just bundles it and adds a bit of sugar on top of it. I believe this has to be carefully looked at in the decidim-design repo.

Can you bring this issue there?

lastpotion commented 7 years ago

Sure, I'll move it right now :)