decidim-vocdoni / decidim-module-vocdoni

(WIP) A module for Decidim that brings an elections component based on the Vocdoni SDK and API
GNU Affero General Public License v3.0
7 stars 0 forks source link

Election administration and frontend #1

Closed andreslucena closed 1 year ago

andreslucena commented 1 year ago

This PR add the initial CRUD for Elections. It was extracted and adapted from decidim-elections.

By adapted I mean mostly:

  1. Removing unnecessary features (like Trustees)
  2. Changing the namespace from Elections to Vocdoni
  3. Changing a bit the data model to adapt it to our needs

In the meantime I found a couple of bugs that I'd need to check out if I can reproduce them with other module, as they seem like they were bugs on the generator (like 2dcdc9580f300300f31c67416439244b40911e25 ee73af5cffab3fb2e661b1ce02b0f397672f4808 1fbde177c6086f29a0dbc70185963b898c311d96 5393b792031209d2387f63323a55e6c1c4ca7489)

Finally as this is also adding lots of specs, I've added the GH Actions CI configuration.

Fixes #5

Testing

andreslucena commented 1 year ago

Everything good @andreslucena , nice job!

A part from a little thing in the readme, do you thing we should rename the component to something like "Vocdoni Elections"? I think that seeing only "Vocdoni" might be confusing for admins.

I agree. Its done in e1f72c6572bec8a96622ab2d2872177c087c283c

I think in my first version I had this name but I didn't like that most of the other modules have only one word and this would break a bit the UI. Seeing it with a fresh pair of eyes, I see that actually "Elections (Vocdoni)" isn't that far from "Accountability" (20 vs 15 characters). This is how it looks like:

Selection_490