search

decidim-vocdoni / decidim-module-vocdoni

(WIP) A module for Decidim that brings an elections component based on the Vocdoni SDK and API
GNU Affero General Public License v3.0
7 stars 0 forks source link

Fix and improve details on the setup and voting flow #36

Closed andreslucena closed 1 year ago

andreslucena commented 1 year ago

This PR introduces multiple changes mostly related to #35 and copies (from #32 and #33).

Most notably:

  1. View the number of credits available in Admin's steps
  2. Add "Fix it" links to SetupForm errors - So it's easier to admins to find out where they can solve the error.
  3. Add Vocdoni logo on Admin's steps and Add Vocdoni logo on Voting booth
  4. Add secretUntilTheEnd setting on Election - This setting configures on the Vocdoni API if the election has to be secret until the end date. If not, the results are visible in real-time.
  5. Change vote verification step on Voting booth

There area also a couple refactors of the code to make it easier to maintain.

As I said, there are lots of changes on little details, texts, and (mostly) mini-improvements on the flow. Most of them come from feedback given by @ferranrego and @carolromero.

andreslucena commented 1 year ago

I've been able to perform the whole process

🥳

I've encountered this strange thing having to add the url of the vocdoni api to be able to vote.

I understand that's related to the bug that we were talking last week where there's a first request that gives 400 when checking with the Census (but then it seems to work well after that)? Or is that you can't make any vote if you don't set up the URL?

Also I see the results in Decidim but looks that the vocdoni explorer does not show the results.

I've seen this kind of behavior from the Vote Explorer to. I think it's just a random bug on their side.

andreslucena commented 1 year ago

Maybe we need to tell the api to publish the results?

At least with our current setup, we don't need to tell them to publish the results, as that's done automatically on their side when the "end time" has arrived.

microstudi commented 1 year ago

I understand that's related to the bug that we were talking last week where there's a first request that gives 400 when checking with the Census (but then it seems to work well after that)? Or is that you can't make any vote if you don't set up the URL?

Yes, the same, the bug is that the object "client" does not sets up the property "url" according to the env variable.