search

decidim-vocdoni / decidim-module-vocdoni

(WIP) A module for Decidim that brings an elections component based on the Vocdoni SDK and API
GNU Affero General Public License v3.0
7 stars 0 forks source link

Bump @vocdoni/sdk package from v0.0.3-alpha to v0.0.4-alpha #45

Closed andreslucena closed 1 year ago

andreslucena commented 1 year ago

Last week we have v0.0.4-alpha published, and it introduced a backward incompatible change in the API, so we need to update.

See the CHANGELOG: https://github.com/vocdoni/vocdoni-sdk/blob/v0.0.4-alpha/CHANGELOG.md

I also needed to do a couple of changes related to this new version:

  1. Drop validation for at least one photo/attachment on Election Setup: it's no longer necessary
  2. Add value attribute to Answers: see details in the commit message
  3. Add a workaround for the cases where the client.url is not set: This one was detected by @microstudi multiple times before, but I couldn't reproduce it. Now I've caught it a few times, so I introduced a workaround
  4. Show an error message when maxVoteOverwrites has reached: this is a new feature and while testing I found it, so I prefer to show an error message specific for this

Testing

All the setup/voting/etc should work as before, with these differences:

  1. No longer necessary to have a photo/attachment in the Election
  2. A new check in the Setup that goes away with a click on "Fix it"
  3. During voting, it should work consistently
  4. If the voter votes another time and there isn't any vote, we show an error message
andreslucena commented 1 year ago

Do you think we could come up with a totally automatic solution to create these "values" (btw I'd call them "index" instead) and leave the admin out of this?

Great to see this comment 😄 @carolromero mentioned this while reviewing it and we agreed that indeed this should be done automatically as it's an implementation detail, an admins shouldn't care about this. This was done in #47 (commit c7df91abe037de4c355cc67af9d7f3b9355f704f)