decidim / decidim-bulletin-board

GNU Affero General Public License v3.0
5 stars 6 forks source link

Fix broken check of results during e2e tests #206

Closed leio10 closed 3 years ago

leio10 commented 3 years ago

This PR fixes a bug during E2E tests: the correctness of the results were not being checked. This prevented a bug on the results calculation on the dummy voting scheme to be catched. That bug is also fixed on this PR. Other fixes on the dummy scheme are included in the PR:

Finally, the release process was modified to use commit messages without prefixes.

codecov-commenter commented 3 years ago

Codecov Report

Merging #206 (e5726db) into develop (54dd8dc) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #206      +/-   ##
===========================================
+ Coverage    69.04%   69.05%   +0.01%     
===========================================
  Files           95       95              
  Lines         1615     1616       +1     
===========================================
+ Hits          1115     1116       +1     
  Misses         500      500              
Impacted Files Coverage Δ
...app/services/voting_scheme/dummy/bulletin_board.rb 82.95% <100.00%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 54dd8dc...e5726db. Read the comment docs.