search

decidim / decidim-bulletin-board

GNU Affero General Public License v3.0
5 stars 6 forks source link

Remove production database ENV VARs #212

Closed andreslucena closed 2 years ago

andreslucena commented 3 years ago

While setting up a local instance of the bulletin board server app, I've seen a couple of settings in config/database.yml that didn't make much sense for me, as this already can be implemented through the default ENV VARS (DATABASE_USERNAME and DATABASE_PASSWORD).

As they'd be difficult to explain in the documentation I think it'd be better to just drop them.

I've made a little archeology and it comes from the initial commit.

codecov-commenter commented 3 years ago

Codecov Report

Merging #212 (4cfb23c) into develop (d93bd05) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #212   +/-   ##
========================================
  Coverage    69.05%   69.05%           
========================================
  Files           95       95           
  Lines         1616     1616           
========================================
  Hits          1116     1116           
  Misses         500      500

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d93bd05...4cfb23c. Read the comment docs.