search

decidim / decidim-bulletin-board

GNU Affero General Public License v3.0
5 stars 6 forks source link

Make decidim-bulletin_board gem compatible with Rails 7 #283

Closed ahukkanen closed 1 year ago

ahukkanen commented 2 years ago

Right now the decidim-bulletin_board ruby client gem is locked to Rails 6: https://github.com/decidim/decidim-bulletin-board/blob/e7bd90bc133ad2360d988a3b4b07cd8c7c0f94c4/bulletin_board/ruby-client/decidim-bulletin_board.gemspec#L27

In order to continue the Decidim Rails 7 upgrade, we need to first make this gem compatible with Rails 7.

I have not yet investigated whether anything is incompatible with Rails 7 right now but I'm opening this so that we can track those issues here.

ahukkanen commented 2 years ago

The Rails 6.x lock was added at #202 in this commit: https://github.com/decidim/decidim-bulletin-board/pull/202/commits/97fec23304dabd232090662c4b5b7185c1196032

The next commit after that updated the dependencies: https://github.com/decidim/decidim-bulletin-board/pull/202/commits/cee73b5e6b9f00df67e8afa5188c6d4eb890c938

Soon after that Rails released the first 7.alpha release, so this was probably just to ensure the client gem still works with Rails 6 which is used in Decidim.

I believe we just need to get rid of this lock and test that everything still works once we bump the dependencies to Rails 7.