Category-subcategory misbehaviour with proposals

[xabier]

This is a Bug Report

:tophat: Description

• What went wrong? When a proposal belongs to a category that doesn't have subcategories the category doesn't show at the admin panel, nor when selecting filter by category on the proposal chart navigation panel.

• What did you expect should have happened? That categories are shown, also subcategories. This distinction needs to be made.

• What was the config you used? Decidicim.barcelona

• What stacktrace or error message from your provider did you see? none

:clipboard: Additional Data

• Decidim deployment where you found the issue: decidim.barcelona

• Browser & version: firefox

• Screenshot:

• Error messages: none

• URL to reproduce the error: https://www.decidim.barcelona/admin/participatory_processes/12/features/5/manage/proposals?feature_id=5&page=2&participatory_process_id=12

[xabier]

Mmmm, it seems that this mistake is the result of deleting subcategories. So it needs to be rewritten: when subcategories are deleted, the proposal should inherit the category it belonged to

[andreslucena]

IMHO this kind of deletion and renaming need to be clear and explained well before the destructive action. It's tricky to do it right.

For instance, Discourse doesn't allow to delete an user if the user has any post, you can only anonimize it; if you really want to delete it, first you need to delete the posts:

On this case, my proposal is that before deleting a Subcategory/Category that has any content associated, we should give a warning like "you can't delete this category until you move or delete all the posts that belongs here". @xabier how do you see something like that?

[xabier]

@andreslucena sounds good to me, we were experimenting with metadecdim process, cleaning categories, this should not happen with participatory processes, at most proposals should be potentially re-categorizable.

I think it is good to show the warning and to make impossible to delete a non-empty category. As I said it would be good to have the option to re-categorize a proposal (this doesn't change the content, although some misuses of this functionality are imaginable).

[mrcasals]

I'm +1 on not deleting the category if it has any content first