[EPIC] Change "valuator" for "evaluator"

[NilHomedes]

Is your feature request related to a problem? Please describe. We are using the term "Valuator" and it is not correct. We should move to "Evaluator".

Describe the solution you'd like Change all the terms from "Valuator" to "Evaluator".

This is a role in the admin dashboard and have some functionalities in the proposals component.

[request-info[bot]]

It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR!

[greenwoodt]

Hi @NilHomedes thanks for assigning me the issue. I've noticed this role also exists in other modules too other than Proposals such as a Assemblies & Conferences:

decidim-assemblies/app/permissions/decidim/assemblies/permissions.rb:      # Valuators can only read the assembly components
decidim-assemblies/config/locales/en.yml:            valuator: Valuator
decidim-assemblies/spec/system/admin/valuator_checks_components_spec.rb:describe "Valuator checks components" do
decidim-conferences/app/permissions/decidim/conferences/permissions.rb:      # Valuators can only read components
decidim-conferences/config/locales/en.yml:            valuator: Valuator
decidim-conferences/spec/system/admin/valuator_checks_components_spec.rb:describe "Valuator checks components" do

Will these roles also have to be adapted?

Also while on the topic of adapting this terminology, would changing this need to take place on a code level? Essentially adapting files (specs, value types, controllers etc) to suit Evaluator? -

decidim-proposals/app/commands/decidim/proposals/admin/assign_proposals_to_valuator.rb:      class AssignProposalsToValuator < Decidim::Command
decidim-proposals/app/commands/decidim/proposals/admin/assign_proposals_to_valuator.rb:            event_class: Decidim::Proposals::Admin::ProposalAssignedToValuatorEvent,
decidim-proposals/app/commands/decidim/proposals/admin/unassign_proposals_from_valuator.rb:      class UnassignProposalsFromValuator < Decidim::Command
decidim-proposals/app/controllers/decidim/proposals/admin/valuation_assignments_controller.rb:          Admin::AssignProposalsToValuator.call(@form) do
decidim-proposals/app/controllers/decidim/proposals/admin/valuation_assignments_controller.rb:          Admin::UnassignProposalsFromValuator.call(@form) do
decidim-proposals/app/events/decidim/proposals/admin/proposal_assigned_to_valuator_event.rb:      class ProposalAssignedToValuatorEvent < Decidim::Events::SimpleEvent
decidim-proposals/app/models/decidim/proposals/valuation_assignment.rb:    # A valuation assignment links a proposal and a Valuator user role.
decidim-proposals/app/models/decidim/proposals/valuation_assignment.rb:    # Valuators will be users in charge of defining the monetary cost of a
decidim-proposals/app/permissions/decidim/proposals/admin/permissions.rb:          # Valuators can only perform these actions
decidim-proposals/app/presenters/decidim/proposals/admin_log/valuation_assignment_presenter.rb:            valuator_role_id: "Decidim::Proposals::AdminLog::ValueTypes::ValuatorRoleUserPresenter"
decidim-proposals/app/presenters/decidim/proposals/admin_log/value_types/valuator_role_user_presenter.rb:        class ValuatorRoleUserPresenter < Decidim::Log::ValueTypes::DefaultPresenter
decidim-proposals/config/locales/en.yml:          valuator_role_id: Valuator name
decidim-proposals/config/locales/en.yml:            valuators: Valuators
decidim-proposals/config/locales/en.yml:            success: Valuator unassigned from proposals successfully.
decidim-proposals/config/locales/en.yml:            valuator: Valuator
decidim-proposals/config/locales/en.yml:            valuators: Valuators
decidim-proposals/spec/commands/decidim/proposals/admin/assign_proposals_to_valuator_spec.rb:      describe AssignProposalsToValuator do
decidim-proposals/spec/commands/decidim/proposals/admin/unassign_proposals_from_valuator_spec.rb:      describe UnassignProposalsFromValuator do
decidim-proposals/spec/system/admin/admin_manages_proposal_valuators_spec.rb:        expect(page).to have_content("Valuator unassigned from proposals successfully")
decidim-proposals/spec/system/admin/admin_manages_proposal_valuators_spec.rb:        expect(page).to have_content("Valuator unassigned from proposals successfully")
decidim-proposals/spec/system/admin/admin_manages_proposal_valuators_spec.rb:      expect(page).to have_content("Valuator unassigned from proposals successfully")
decidim-proposals/spec/system/admin/valuator_manages_proposals_spec.rb:describe "Valuator manages proposals" do
decidim-templates/spec/system/admin/valuator_uses_proposal_answer_templates_spec.rb:describe "Valuator uses proposal answer templates" 

Perhaps that one will need to be approved by @andreslucena before going ahead.

[NilHomedes]

Hey @greenwoodt !

Will these roles also have to be adapted?

Yes, also the role in assemblies and processes needs to be changed.

Also while on the topic of adapting this terminology, would changing this need to take place on a code level? Essentially adapting files (specs, value types, controllers etc) to suit Evaluator? -

I think yes, but let's see what @andreslucena says here.