decidim / decidim

The participatory democracy framework. A generator and multiple gems made with Ruby on Rails
https://decidim.org/
GNU Affero General Public License v3.0
1.48k stars 405 forks source link

Add hyperlink to title in admin dashboard meetings listing #9393

Closed roxanaopr closed 2 years ago

roxanaopr commented 2 years ago

Describe the bug At the moment, in admin dashboard - pick a topic - proposal or meeting component, it can be noticed that the tile of the proposals are hyperlinked and take the user to the proposal page but the meetings are not hyperlinked within the list.

To Reproduce Steps to reproduce the behavior:

  1. Go to admin dashboard
  2. Click on meetings component
  3. Hover the meeting's title from listing page
  4. No link to the meeting's page

Expected behavior Meeting's title from listing page should have a link that can redirect the user to the corespondent page.

Screenshots image image

Stacktrace If applicable, add the error stacktrace to help explain your problem.

Extra data (please complete the following information):

Additional context Add any other context about the problem here. For instance, add Metadecidim link.

andreslucena commented 2 years ago

We talked about this a couple weeks ago with @carolromero. I think that we didn't reach an agreement about the best course of action and that we would rethink this when we arrive to these pages in the admin redesign.

The problem is a general lack of consistency on these titles:

Spaces

  1. Process: link to edit page
  2. Assemblies: link to edit page
  3. Initiatives: link to edit page
  4. Consultations: link to edit page
  5. Votings: link to edit page

Components

  1. Accountability: links to the filtered children's results
  2. Blog: no link
  3. Budgets: link to public page on budgets. On projects, no link.
  4. Debates: link to public page
  5. Elections: link to public page
  6. Meetings: no link
  7. Page: not applicable (it doesn't have a manage table page)
  8. Proposal: link to detail/answer private page
  9. Sortitions: no link
  10. Survey: not applicable (it doesn't have a manage table page)

So, seeing how it works, I think that:

  1. for Spaces it should work as it's now (Edit page)
  2. for Components it should always be the Public page, as some don't have an edit form (for instance user generated Meetings or Proposals)

But this is my personal opinion and would like to hear other people from @decidim/product input.

andreslucena commented 2 years ago

Talked with @decidim/product in our meeting, and we think that for the moment we should just link to the public page in the Components, as that's what's always enabled. Ideally, this be the 'edit' page, but in some cases this can be a participant generated content, and it'll not have this page for admins.

This could be changed in the redesign, but at the moment we're just starting to talk about these details.

andreslucena commented 2 years ago

After further discussion on #9400, and further discussion with @carolromero we've changed of hypothesis:

  1. We'll drop all the links on titles as we can't find a consistent page that applies on every case
  2. We'll add the View (Eye icon) and Edit (Pencil icon) where it isn't
roxanaopr commented 2 years ago

@andreslucena on Participatory processes listing page (https://nightly.decidim.org/admin/participatory_processes) there are multiple links applied on the title of the process, based on permissions: Screenshot from 2022-06-21 11-57-53 On that page, we have the following actions: Export all, Duplicate, Configure, Preview Screenshot from 2022-06-21 12-00-46 What behaviour should we have for this listing page?