search

decidim / metadecidim

This is the repository for the code of Metadecidim community, we experiment with the new features, we are an experimental community
https://meta.decidim.org
8 stars 7 forks source link

Bump decidim from v0.28.0 to v0.28.1 #128

Closed andreslucena closed 2 months ago

andreslucena commented 3 months ago

As the title says, there's a new version of Decidim so we need to update

andreslucena commented 3 months ago

To finish the update process, once this is deployed in the production database we'll need to run

bin/rails decidim:upgrade:fix_orphan_categorizations

See more information at https://github.com/decidim/decidim/releases/tag/v0.28.1

andreslucena commented 3 months ago

(58:6) /Users/fbo/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/decidim-meetings-0.28.1/app/packs/stylesheets/decidim/meetings/_item.scss The min-w-24 class does not exist. If min-w-24 is a custom class, make sure it is defined within a @layer directive.

I can reproduce this same error locally with

SECRET_KEY_BASE=potato RAILS_ENV=production bin/rails assets:precompile

I think it's related to the tailwindcss version that we're using and the backport that introduced this change in v0.28 (#12787). This is using a directive that isn't available in the version of tailwind that we're using in v0.28.

I made a quick fix in bfb306cf7cadf6ad9b8602c16b327d404bd908e7, just to check out if this is indeed the problem, so we can also introduce that change in release/0.28-stable (and do a v0.28.2 with this fix).

This is something that @microstudi mentioned a couple of weeks ago, but I could only reproduce in this app with this change. Locally with a new v0.28.1 app I could not reproduce this bug, as I see that it generates the app with tailwind 3.4.4.

I think the actual issue is that we're using the caret character (^) and this applies to minor and patch versions, and we should use the tilde character (~), that applies only to patch versions. With that, I understand that we would have detected the problem in CI (as we should have done).