search

decidim / metadecidim

This is the repository for the code of Metadecidim community, we experiment with the new features, we are an experimental community
https://meta.decidim.org
8 stars 7 forks source link

Remove leftovers from proposals' states overrides #131

Closed andreslucena closed 3 months ago

andreslucena commented 3 months ago

In #121 we have added some overrides, that we removed most of them we we've done the v0.29.0.rc3 update as this feature (changing proposal states strings and colors) is native now.

This PR removes a few leftovers from it.

andreslucena commented 3 months ago

Are these custom states in the database? As far as I remember the overrides that I made were 100% for helpers/strings/cell.

andreslucena commented 3 months ago

As we have two custom states. We should have the translations for them:

Just to leave it here, but I think this behavior that you've seen was related to the bug described at #13219, so I think we don't need to add these i18n strings. Maybe when we deploy the next RC can you check out if the bug is still there?

fblupi commented 3 months ago

As we have two custom states. We should have the translations for them:

Just to leave it here, but I think this behavior that you've seen was related to the bug described at #13219, so I think we don't need to add these i18n strings. Maybe when we deploy the next RC can you check out if the bug is still there?

Sure!