search

decile-team / submodlib

Summarize Massive Datasets using Submodular Optimization
MIT License
84 stars 33 forks source link

cpp/submod/SetCover.cpp does not build for C++20 #1

Closed nab170130 closed 3 years ago

nab170130 commented 3 years ago

The C++ implementation of the SetCover function uses the word 'concept' regularly as a variable name; however, 'concept' is a reserved keyword for C++20 and causes compilation issues during pip installation.

vishkaush commented 3 years ago

Removed occurence of "concept" in CPP codebase. Commit bf73bf6a06ec83aa58f6e8fec685a87da23a98cf

vishkaush commented 3 years ago

Closed it by mistake. Pls verify if pip install goes through now and close this issue after verification.

nab170130 commented 3 years ago

The concept keyword issue is resolved; however, there are other compilation issues. I will open a new issue to discuss them.