decile-team / submodlib

Summarize Massive Datasets using Submodular Optimization
MIT License
84 stars 33 forks source link

Slight C++ Restructuring #5

Closed nab170130 closed 3 years ago

nab170130 commented 3 years ago

Made non-void SetFunction member functions pure virtual to placate compiler errors; updated other member functions to match function signature.

Notes:

vishkaush commented 3 years ago

The changes look good. However, I just noted that the the tests/test_all.py in the repo right now had some tests commented out. So probably all tests have not yet run. Can you pull my commit cb877233f615f9d8ad1b5cd1861a30794946d243 and rerun the tests? A total of 685 tests should run and the following five (only) should fail. They are actually normal, but wrongly reported as failures right now. FAILED tests/test_all.py::TestAll::test_sparse_cpp_eval_groundset[LogDeterminant] FAILED tests/test_all.py::TestAll::test_sparse_py_eval_groundset[LogDeterminant] FAILED tests/test_all.py::TestAll::test_stochastic_lazierThanLazy[LogDeterminant] FAILED tests/test_all.py::TestAll::test_mi_dense_cpp_eval_groundset[GraphCutConditionalGain] FAILED tests/test_all.py::TestAll::test_mi_dense_py_eval_groundset[GraphCutConditionalGain] Once all tests pass (Except the above five), this will be good to merge.