decioferreira / bootstrap-generators

Bootstrap-generators provides Twitter Bootstrap generators for Rails
MIT License
351 stars 77 forks source link

SASS Precision #40

Open ttilberg opened 8 years ago

ttilberg commented 8 years ago

Hello, I've been happily using this gem to get off the ground with Rails + Bootstrap.

I've come across an issue where a button is 1 pixel too small in height. I think I've traced it down to a SASS configuration thing related to SASS Number Precision.

image

https://github.com/twbs/bootstrap-sass#sass-number-precision

https://github.com/twbs/bootstrap-sass/issues/595

I'm not fluent enough with Rails to understand how/where to monkeypatch this configuration change. If it's something that the gem could be conscious of during the bootstrap:install task (or wherever it needs to end up?), I think it would be relevant for all of your users.

If this is a simple configuration one-liner somewhere in config/ I'd love to know. I tried adding

::Sass::Script::Number.precision = [8, ::Sass::Script::Number.precision].max

to config/application.rb randomly, but it didn't do the trick. Probably because it's not what I needed to do ;)

Any tips are appreciated.