search

decioferreira / bootstrap-generators

Bootstrap-generators provides Twitter Bootstrap generators for Rails
MIT License
351 stars 77 forks source link

Remove `content_tag_for` for Rails 5 compatibility #46

Closed ttilberg closed 7 years ago

ttilberg commented 7 years ago

content_tag_for was extracted to a separate gem for Rails 5. This commit fixes the dependency without having to add the new gem.

This fixes #43.

I've tested this in Rails 5, but not other versions. The cloned tests are throwing errors about missing bootstrap files, so I can't say much about the tests for this other than "it works for my project."

jasonnoble commented 7 years ago

Confirmed this PR would fix #43 (tested with Rails 5.1.0). @ttilberg could we get this merged and a new version of the gem pushed?

Thanks @ttilberg!

ttilberg commented 7 years ago

@jasonnoble I wish I was the maintainer of such a handy tool!

But I believe you meant to reference @decioferreira