search

decioferreira / omniauth-linkedin-oauth2

A LinkedIn OAuth2 strategy for OmniAuth.
MIT License
117 stars 147 forks source link

Add support for returning secure avatar when secure_image_url is set. #14

Closed kenips closed 10 years ago

kenips commented 10 years ago

Similar to omniauth-twitter and omniauth-facebook, when secure_image_url is set, the secure avatar URL is returned for picture-url field.

decioferreira commented 10 years ago

Hi @kenips, wouldn't it be easier to add picture-url;secure=true to the profile fields? If you think so, maybe the way to go would be to update the readme file.

kenips commented 10 years ago

I'd say since omniauth-twitter and omni-facebook has established this it'd makes sense to add and possibly look at implementing the other options too. Thoughts?

jbnunn commented 10 years ago

I agree @kenips, since devs often combine multiple OmniAuth strategies, I think keeping their respective functionalities as similar as possible is the best approach.

Sent from my iPhone

On Sun, Dec 15, 2013 at 11:15 AM, Ken Ip notifications@github.com wrote:

I'd say since omniauth-twitter and omni-facebook has established this it'd makes sense to add and possibly look at implementing the other options too. Thoughts?

Reply to this email directly or view it on GitHub: https://github.com/decioferreira/omniauth-linkedin-oauth2/pull/14#issuecomment-30613398

heythisisnate commented 10 years ago

Looks like a good improvement. Could you add a simple spec to help document that option?