search

decioferreira / omniauth-linkedin-oauth2

A LinkedIn OAuth2 strategy for OmniAuth.
MIT License
117 stars 147 forks source link

Add OpenID Support #77

Closed jclusso closed 9 months ago

jclusso commented 1 year ago

Credit to @antonioJASR for puting most of this togather in LinkedIn launched a new SignIn product #74.

I don't know if there is a reason to support the old ways anymore, but if there is, I can make a separate gem.

babilonczyk commented 1 year ago

Could you revert last commit and add @antonioJASAR as a Co-author? I feel it would be more appropriate then a being credited. Unless he's ok with this.

jclusso commented 1 year ago

@babilonczyk I've force pushed the changes and added @antonioJASR on the commit.

jclusso commented 1 year ago

@babilonczyk thanks for the fast approval! Just curious when you plan to release this. Going to be including in a release of my own and wanted to switch back to the main release if it's going to be soon.

babilonczyk commented 1 year ago

FYI, it's not my repo, I'm waiting myself for this as well. cc: @decioferreira

jclusso commented 1 year ago

FYI, it's not my repo, I'm waiting myself for this as well. cc: @decioferreira

Hah, I totally wasn't paying attention!

JoeKaldas commented 1 year ago

Is this going to be released soon?

thomasmalbaux commented 1 year ago

We're also interested in this (and are grateful for your work @jclusso!).

@decioferreira Let us know if there's anything we can do to help get this to be reviewed and merged :-)

jclusso commented 1 year ago

I debated making a separate gem originally... maybe I should just do that since maybe this change is too drastic?

decioferreira commented 1 year ago

@jclusso I think that would be the best option, since changing this gem might have unintended consequences, and since I don't really have been using this gem nor develop in ruby for quite a while now, it becomes hard for me to be guiding the development of the gem. I would be more than happy to add a reference to your new gem on the README once it is available. (Thanks to everyone involved in this work btw)

thomasmalbaux commented 1 year ago

That is a very good point @jclusso and indeed, I think that would make sense if you're up for it. Good thinking.

Maybe most users of this gem use it in a single-app manner but not everybody does (we don't!) so making sure not to break compatibility with the LinkedIn old flow can be quite important.

jclusso commented 1 year ago

Alright all, I've created omniauth-linkedin-openid. You can simply swap in your gem file omniauth-linkedin-openid and all should work. @decioferreira I credited your work at the bottom!

thomasmalbaux commented 1 year ago

Awesome, many thanks @jclusso, we'll try it out soon :-)

And thanks again @decioferreira for the work you've done with the gem over the years, it has worked like a charm.

yaroslavrick commented 1 year ago

Could you merge it when its ready? :)

jclusso commented 1 year ago

Could you merge it when its ready? :)

A decision was made that this was better off as a separate gem which can be found at omniauth-linkedin-openid.

yaroslavrick commented 1 year ago

Could you merge it when its ready? :)

A decision was made that this was better off as a separate gem which can be found at omniauth-linkedin-openid.

Thank you for info!

decioferreira commented 9 months ago

Given a new gem jclusso/omniauth-linkedin-openid has been created, I think this can now be closed. I will update the README to mention this new gem.