search

decipher3114 / Revancify

The only revancify
Apache License 2.0
791 stars 52 forks source link

Add app name and version to output APK name #28

Open KobeW50 opened 12 months ago

KobeW50 commented 12 months ago

Currently, the patched APKs are placed in folders giving the app name and version but the APK itself is only named after the source, such as base-Revanced-Extended.apk or base-Revanced.apk.

It would be useful to include the app name and/or version number in the APK file name because if you share the APK with someone they don't know which app and version it is. Also when you search in your file manager for APK files there may be several APKs with the same name (shown in the screenshot below).

SmartSelect_20231002_140733_My Files.jpg

The new naming format can be something like:

<source>_<app name>_<version>.apk

(ie: Revanced_YouTube_18.32.39.apk)

KobeW50 commented 10 months ago

Edit: The file name can even include the patch version that was used, although this is less important to add.

So the format may be:

<source>_<patch version>_<app name>_<version>.apk

(ie: Revanced_v2.199.0_YouTube_18.32.39.apk)

KobeW50 commented 10 months ago

@decipher3114 I'd like to PR for this (if it is within my technical ability)

Would it be as simple as finding and replacing all instances of base-$sourceName.apk to $sourceName_$appName_$appVer.apk?

For example, in these lines: https://github.com/decipher3114/Revancify/blob/main/main.sh#L325-L326