No support for multiple adsizes

arifje commented 7 years ago

See: https://developers.google.com/mobile-ads-sdk/docs/dfp/android/banner#multiple

Would be great ;-)

deckameron commented 7 years ago

Hi @skoften ,

Are you talking about these adsizes?

If so, they are all already implemented as you can see here

Use it like this:

var bannerAd = admob.createView({
    top: 0,
    adSizeType: 'BANNER', //RECTANGLE, FULLBANNER, LEADERBOARD, SMART
    publisherId: 'ca-app-pub-xxxxxxxxxxxxx/xxxxxxx', //USE YOUR PUBLISHER ID HERE
    testing: true
}); 
window.add(bannerAd);

deckameron commented 7 years ago

Did you manage to get it working @skoften?

arifje commented 7 years ago

Hi Deckameron,

Sorry for the late reply, but that's not what I meant with multiple adSizes. I need to pass multiple adsizes as an argument to the view, because our DFP-tag can serve multiple ad formats: it can be a 320x50, but also 320x100. The view needs to adapt when one of these banners is displayed/served.

From my previous link:

DFP allows you to specify multiple ad sizes which may be eligible to serve into a PublisherAdView. Before implementing this feature in the SDK, create a line item targeting the same ad unit which is associated with different size creatives.

The Ti.DFP module also was updated with this feature a while ago: https://github.com/jpriebe/ti.dfp/pull/7

deckameron commented 7 years ago

I am so sorry @skoften. I didn't understand it right. I will implement it as soon as possible.

arifje commented 7 years ago

Awesome!

deckameron commented 6 years ago

Just implemented it!

arifje commented 6 years ago

nice!

deckameron / Ti.Android.Admob

No support for multiple adsizes #5