search

deckar01 / task_list

Markdown Task List feature components
MIT License
9 stars 7 forks source link

Don't Update Code Blocks #13

Closed deckar01 closed 7 years ago

deckar01 commented 7 years ago

Prevent updates from modifying list items inside code blocks. Ignore lines inside code blocks during the scan instead of trying to remove all code blocks with a regex before the scan.

Fixes #3

filipalacerda commented 7 years ago

Awesome 👍 Looks good to me :)

Maybe we can keep the comments explaining what the regex does ;)

deckar01 commented 7 years ago 
# Used to filter out code fences from the source for comparison only.
- # http://rubular.com/r/x5EwZVrloI
- # Modified slightly due to issues with JS

The link doesn't apply to the new regexes. "modified slightly" meant the regex in the link was only modified slightly.

I can add a link to the issue or a markdown reference about code blocks, and add a comment about not updating list items inside code fences.

filipalacerda commented 7 years ago

👍 let me know if you need any help 😄

deckar01 commented 7 years ago

@Lacerda Thanks for reviewing. Comments and links added.

Feel free to review, merge, or assign back as needed.

filipalacerda commented 7 years ago

Thank you! I think it is ready to merge!

Thanks for all the work 😄