Phantom Tests Not Running

deckar01 / task_list

Markdown Task List feature components

MIT License

9 stars 7 forks source link

Phantom Tests Not Running #28

Closed deckar01 closed 4 years ago

deckar01 commented 4 years ago

The setup for the phantom tests is extremely fragile. The server starts, waits 3 seconds, and assumes the tests finished then exits. It does not appear to actually be running the js tests.

digitalmoksha commented 4 years ago

I don't know much about the JS testing frameworks, but if it's any help, GitLab has started migrating to using Jest

deckar01 commented 4 years ago

I got it working by swapping PhantomJS out for Karma + Chrome Headless. I also used the webpack plugin for karma to compile the coffeescript on the fly instead of serving it with rackup. It should at least error if the tests stop working now. #29

digitalmoksha commented 4 years ago

👍