Closed ecpplus closed 3 years ago
@deckar01 Thank you for merging my PR and published a new version of gem.
When you have time, could you please publish a new version of npm package as well? Thank you very much:bow: https://www.npmjs.com/package/deckar01-task_list
Sorry for the delay. https://www.npmjs.com/package/deckar01-task_list/v/2.3.2
Thank you very much for the release:pray:
But it seems there is missing dist
directory that existed on version 2.3.1.
Which is supposed to contain CSS and JS.
I wonder if the build got something wrong.
deckar01-task_list
βββ LICENSE
βββ package.json
βββ README.md
0 directories, 3 files
deckar01-task_list
βββ dist
βΒ Β βββ task_list.css
βΒ Β βββ task_list.js
βββ LICENSE
βββ package.json
βββ README.md
1 directory, 5 files
Apparently the latest npm version dropped support for the prepublish hook, so npm publish
never triggered npm build
. That's what I get for setting up a new dev environment. π
I unpublished 2.3.2, fixed the hook, and published 2.3.3. Thank you for catching that.
Thank you for your quick fix!:bow: It works perfectly:+1:
When the closing code fence includes trailing spaces, script doesn't detect the end of it.
For example:
I'm not sure about other markdown flavors, but CommonMark and GitHub Flavored Markdown (based on CommonMark though) specs says trailing spaces are ignored.
https://spec.commonmark.org/0.29/#fenced-code-blocks https://github.github.com/gfm/#fenced-code-blocks
I don't think there would be a big side effect if it allows trailing spacesπ