deckar01 / task_list

Markdown Task List feature components
MIT License
9 stars 7 forks source link

Allow trailing spaces in endFencesPattern #33

Closed ecpplus closed 3 years ago

ecpplus commented 3 years ago

When the closing code fence includes trailing spaces, script doesn't detect the end of it.

For example:

```
Hello
``` <- there are trailing spaces

I'm not sure about other markdown flavors, but CommonMark and GitHub Flavored Markdown (based on CommonMark though) specs says trailing spaces are ignored.

https://spec.commonmark.org/0.29/#fenced-code-blocks https://github.github.com/gfm/#fenced-code-blocks

The closing code fence may be indented up to three spaces, and may be followed only by spaces, which are ignored.

I don't think there would be a big side effect if it allows trailing spacesπŸ™‚

deckar01 commented 3 years ago

https://rubygems.org/gems/deckar01-task_list/versions/2.3.2

ecpplus commented 3 years ago

@deckar01 Thank you for merging my PR and published a new version of gem.

When you have time, could you please publish a new version of npm package as well? Thank you very much:bow: https://www.npmjs.com/package/deckar01-task_list

deckar01 commented 3 years ago

Sorry for the delay. https://www.npmjs.com/package/deckar01-task_list/v/2.3.2

ecpplus commented 3 years ago

Thank you very much for the release:pray: But it seems there is missing dist directory that existed on version 2.3.1. Which is supposed to contain CSS and JS. I wonder if the build got something wrong.

Ver 2.3.2

deckar01-task_list
β”œβ”€β”€ LICENSE
β”œβ”€β”€ package.json
└── README.md

0 directories, 3 files

Ver 2.3.1

deckar01-task_list
β”œβ”€β”€ dist
β”‚Β Β  β”œβ”€β”€ task_list.css
β”‚Β Β  └── task_list.js
β”œβ”€β”€ LICENSE
β”œβ”€β”€ package.json
└── README.md

1 directory, 5 files
deckar01 commented 3 years ago

Apparently the latest npm version dropped support for the prepublish hook, so npm publish never triggered npm build. That's what I get for setting up a new dev environment. πŸ˜„

I unpublished 2.3.2, fixed the hook, and published 2.3.3. Thank you for catching that.

https://www.npmjs.com/package/deckar01-task_list/v/2.3.3

ecpplus commented 3 years ago

Thank you for your quick fix!:bow: It works perfectly:+1: