search

deckarep / corebench

corebench - run your benchmarks against high performance computing servers with many CPU cores
MIT License
30 stars 2 forks source link

Add AWS support #2

Closed jokebroker closed 6 years ago

jokebroker commented 6 years ago

Hi - have added preliminary AWS support :)

jokebroker commented 6 years ago

Managed to break the api - will review in the .au AM

deckarep commented 6 years ago

@jokebroker I fully expected the API to break since the original implementation was a bit bias to DigitalOcean as that is what was the original implementation as you know.

With that said, this is already looking great and I’m super excited to have AWS instances available for this.

Let me know when you’re ready for a review.

Thanks for the contribution!

jokebroker commented 6 years ago

Okay, should be ready for review now.

Some fmt/imports cleaning & added corresponding field/method to DoSpinSettings, leaving additional generalisation of the API till perhaps after GCE support goes in.

deckarep commented 6 years ago

Sorry for the delay on this...looks good to me. Thanks for the contribution!

I'll likely follow-up up with some small refactoring in the future with the DO and AWS code to clean up a few things.