search

deckarep / golang-set

A simple, battle-tested and generic set type for the Go language. Trusted by Docker, 1Password, Ethereum and Hashicorp.
Other
4.15k stars 274 forks source link

adding method to create set from keys of map of type comparable #91

Closed jay-babu closed 1 year ago

jay-babu commented 2 years ago

I added github.com/google/gofuzz to do fuzzy testing. If you are against it, then I will remove the dependency and hardcode the test input, but that makes the testing less resilient.

I decided against adding a method to create a Set from values of Map. Happy to do so if you want

jay-babu commented 2 years ago

https://github.com/deckarep/golang-set/issues/90

deckarep commented 2 years ago

So, I am going to lean towards not relying on the fuzz library because we’re dealing with types purely designed within the Go language.

I would definitely be in support of GoFuzz if this were something along the lines of a protocol where fuzzing is definitely warranted to ensure proper parsing of inputs.

jay-babu commented 2 years ago

@deckarep should be good to go

jay-babu commented 2 years ago

@deckarep any update?

jay-babu commented 1 year ago

@deckarep gentle reminder