deckerst / aves

Aves is a gallery and metadata explorer app, built for Android with Flutter.
BSD 3-Clause "New" or "Revised" License
2.77k stars 106 forks source link

When installed by F-droid application name is corrupted. #1279

Closed mutaunt closed 1 week ago

mutaunt commented 2 weeks ago

Describe the bug F-droid displays name as Aves Libre followed by unrecognised character string. Maybe "Gallery and metadata explorer" rendered in wrong chracter set??? When installed the app name also appears as a short string of unrecognised character on the home screen. When openned all is good, correct English language used.

To Reproduce Steps to reproduce the behavior:

  1. Open F-droid on Android 6 device, system language English, with no Aves Libre installed.
  2. Hit "search" buton, type "Aves" and search. Aves Libre appears followed by corrupted string.
  3. Select "Install"
  4. Once installed the Aves icon appears on home screen but the name under the icon is a corrupted string.

Expected behavior English name and description in F-droid, "Aves Libre" name under installed app.

Screenshot_2024-11-08-15-14-02 Screenshot_2024-11-08-15-17-02 aves-logs-20241108_144314.txt

Package: deckers.thibault.aves.libre Installer: org.fdroid.fdroid Aves version: 1.11.17-libre, build 13601 Flutter: stable 3.24.4 Android version: 6.0.1, API 23 Android build: MMB29M.G900FXXU1CPGK Device: samsung SM-G900F Support: dynamic colors=false, geocoder=true, HDR=false Mobile services: not available Connectivity: wifi System locales: en_US Storage volumes: /storage/30C9-A465/, /storage/emulated/0/ Storage grants: Error reporting: false

Screenshots If applicable, add screenshots or screen recordings to help explain your problem. If they are too private for this public space, feel free to [send them by email]

deckerst commented 2 weeks ago

Thanks for the report. Maybe related to the recent inclusion of the "English (Shavian)" locale. It's already the cause for another issue:

deckerst commented 1 week ago

There are 2 issues: 1) for the wrong description in F-droid, cf #1253
2) for the wrong app title in your launcher, it's trickier:

Android 7.0 (API level 24) introduced support for BCP 47 language tags

Ref: https://developer.android.com/guide/topics/resources/providing-resources#AlternativeResources

Given that Shavian is an exotic English flavour, it's only possible to define it with a BCP 47 tag: b+en+Shaw. I thought Android 6 and below would just dismiss such tags, but instead it picks it over the default app title, and that's why you see the app title in Shavian.