deckerst / aves

Aves is a gallery and metadata explorer app, built for Android with Flutter.
BSD 3-Clause "New" or "Revised" License
2.19k stars 86 forks source link

Photo editor #17

Open Donkey-Doug opened 3 years ago

Donkey-Doug commented 3 years ago

Add a basic photo editor with support for:


Examples: Radial blur: screen-0

Inverted radial blur: screen-4

Inverted rectangular blur: unnamed

deckerst commented 3 years ago

Planned but not in the short term, as some other core features and performance issues must be tackle first.

For rotating and mirroring, you can already do so with the image viewer menu. There's a line with 3 icon buttons: rotate CCW, rotate CW, and horizontal flip. They do not modify the image itself, they modify the metadata, so it's lossless.

On Mon, Jan 4, 2021 at 11:45 AM Donkey-Doug notifications@github.com wrote:

Add a basic photo editor with support for:

  • Cropping (free form, 1:1, 16:9)
  • Rotating (I recomment just one button that rotates 90 degrees. Can be pressed multiple times to rotate 180 or 270 degrees)
  • Annotating (drawing lines of varying thickness and color, writing text)
  • Black-and-White filter to remove colors

โ€” You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/deckerst/aves/issues/17, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKBEXK5OPUZC3HZGV66E3LSYETTZANCNFSM4VSMQVGQ .

Subbarao6338 commented 2 years ago

Also add lighten images

RuthlessRuler commented 1 year ago

Any timeline when the Photo Editing Features will be added?

deckerst commented 1 year ago

Nope. I do not have timelines for this personal project. I try to fix bugs as soon as they emerge, but features are just things I'd like to do someday.

Is it troublesome to use another app for editing, like Snapseed?

bornhustler07 commented 1 year ago

Snapseed is close source ๐Ÿ™‚

bornhustler07 commented 1 year ago

If you will consider maybe same day to add photo editor just simple editor kinda like simple gallery app it will be nice๐Ÿ‘

Darkempire78 commented 1 year ago

basic edit is clearly the most important improvements to be made

rusty-snake commented 1 year ago

I think Signal's photo editing is the best way to edit photos ATM if you want OSS. Somebody could make an standalone app for it.

RuthlessRuler commented 1 year ago

Simple Gallery Pro also has a nice feature rich Photo Editing Tools.

mitchwalton commented 1 year ago

Looking forward to a quality photo editor in Aves when he gets to it. However, this app doesn't collect personal info and is a powerful photo editor. Give it a try! If your still concerned about data collection deny it internet permission through the ROM or with Netguard.

https://apkcombo.com/img-ly-photo-video-editor/com.photoeditorsdk.android.app/

Svetov1d commented 1 year ago

built-in editor would be great, add it and i'm switching completely to Aves. I would love to have one app to browse and edit images like simple gallery does

arthuragone commented 10 months ago

The best goal of adding a photo editor within Aves would be the possibility not to modify Exif date and position data. At the moment if you edit your picture with Snapseed as an example, it modify picture date as today and wipe out location data. Same behavior with GrapheneOs internal gallery and editor.

opk12 commented 8 months ago

Calling an external third-party component (Edit menu to open a specialized editor app) is the optimal approach, from a purely software engineering POV. Widespread software design guidelines deprecate reinventing bloat in-app. As a programmer, I value the simplicity and agility of Aves, in comparison to bloated apps. But if implementing an editor were the way to go, what about integrating a lib?

Cons are the bigger app size; the maintainance burden of keeping up with library releases; the risk that the lib becomes unmaintained in the future, with security issues. But reinventing the wheel in this app would be the worst option, heavier on the devs, and the users would not get as a powerful UI.

opk12 commented 8 months ago

Also ImageToolbox, is under active development, featureful, already in F-droid.

rusty-snake commented 8 months ago

Featureful but lacks in UX.

tsutaya0225 commented 7 months ago

I agree that the most basic editing functions are necessary, but I don't think anything more than that should be considered now. (I agree with Donkey-Doug who was the first to speak up). However, I would also like to see crop presets for common photo ratios (3:2, 4:3, 7:5). I am currently getting by with external apps, so I would be very happy if you could implement this when you can afford it.

hj-collab commented 7 months ago

I've switched to Aves from Simple Gallery Pro since ZipoApps acquired Simple Mobile Tools. Hoping for basic editing features in Aves in the future, as Simple Gallery Pro had a great built-in image editor.

guglovich commented 5 months ago

It's the only normal app in F-Froid. I'm looking forward to basic photo cropping.

derei commented 2 months ago

@deckerst I understand there is a lot of work to do ahead, before you may consider adding new features. However, cropping an image is one of the most used features on mobile devices. And yes, I'm sure some will say that "annotation", or adding text, stickers, emoji, is what they use most... or color balance, or whatnot. But if we're bein purely objective, the basic ol' crop feature is not only the one present in all photo gallery apps, even those without advanced editing, but is the most used and useful to have at fingertips.

Whilst for advanced editing there are alternatives, I believe that adding a crop feature as a quick modifier, would only benefit the app, and perhaps it could be released before any major update.

Many thanks.

Iprobablydontknowwhatimdoing commented 9 hours ago

I love snapseed, but it's closed source, and also by google, So they will probably shut it down and they remember it exists.

deckerst commented 9 hours ago

@Iprobablydontknowwhatimdoing let me know when it's in https://killedbygoogle.com/ :D