search

deckerst / aves

Aves is a gallery and metadata explorer app, built for Android with Flutter.
BSD 3-Clause "New" or "Revised" License
2.67k stars 102 forks source link

HDR videos are too bright #924

Open deckerst opened 8 months ago

deckerst commented 8 months ago 
          I don't know if it's related but HDR videos of the pixel 8 pro look super bright - to the point that it looks very bad - on Aves, when compared to the Google Photos app where they look normal.

Example video if it helps looking at the metadata or something: https://nc.djf.lol/s/SYnoFxLKRb2tPbF

Originally posted by @davidfrickert in https://github.com/deckerst/aves/issues/838#issuecomment-1962869699

deckerst commented 8 months ago

In Google Photos, I can see when switching to the HDR video a quick transition from "too bright" to tone-mapped:

I tried different players on the same frame (more or less).

Aves (too bright)

MPV (classic renderer)

MPV (future renderer)

Google Photos

Aves uses for video playback the media_kit package, which uses MPV, and we can see Aves and classic MPV rendering is basically the same, but there's hope with the future MPV renderer. Colors are not as deep as with Google Photos rendering, but it's a big improvement. I'll try and see whether I can switch to it.

davidfrickert commented 8 months ago

Already a nice improvement! From digging around it seems that both Flutter and MPV don't have native support for HDR so they probably map into SDR which could explain the less dark colors even in the "future renderer"? But eh I have no idea about any of this stuff.

https://github.com/flutter/flutter/issues/91241 https://github.com/media-kit/media-kit/issues/615