search

deckgo / deckdeckgo

The web open source editor for presentations
https://deckdeckgo.com
1.64k stars 182 forks source link

lazy-img attributes img-height img-width don't work #1553

Open flatmax opened 2 years ago

flatmax commented 2 years ago

Affected part of DeckDeckGo

Reproduction

Can' use img-width and img-height

Steps to reproduce:

Expected Behavior

The image to resize

Actual Behavior

The image doesn't resize

Environment

peterpeterparker commented 2 years ago

Did you inspect the shadowed dom, are the width and height applied?

As you can see in the component here https://github.com/deckgo/deckdeckgo/blob/00d532ffc7b03795a674984d2fe8d08d57cc3e2e/webcomponents/lazy-img/src/components/lazy-img/deckdeckgo-lazy-img.tsx#L299 width and height should be set if the props are set.

flatmax commented 2 years ago

Oh ok - are you saing that the attributes img-width and img-height aren't working ? I should use the properties instead ?

peterpeterparker commented 2 years ago

Actually I'm saying these should work but asking if you had a look to the shadowed content to see if anything seems not to work as expected?