search

deckgo / starter-kit

The developer kit to create slides with DeckDeckGo
https://deckdeckgo.com
MIT License
47 stars 13 forks source link

Print result does not work #28

Closed Dellos7 closed 5 years ago

Dellos7 commented 5 years ago

Hello @peterpeterparker,

I was just trying the print result button but it seems not to be working, at least from my computer, as shown in this screenshot:

deckdeckgo print

Result is just a blank page. Could you please confirm this?

I've tried it in Chrome and Safari.

Thank you.

David.

peterpeterparker commented 5 years ago

@Dellos7 well spotted, probably one of the last CSS changes is breaking it

UPDATE actually it might be a side effect of a change in Ionic core. The print feature on this Web Component, the DeckDeckGo core, works fine. I've to see if I could do something in the starter kit...

peterpeterparker commented 5 years ago

Yep definitely a style of ion-content shadowed element inner-scroll is blocking the print feature

peterpeterparker commented 5 years ago

@Dellos7 the related commit of this issue solves it partially, as it will only be possible to print using the "print" button in the fab-button (bottom right of the presentation) as a not exposed style of ion-content has to be modified in the shadowed element

also note, the pagination will be improved with the next version of DeckDeckGo (added a page break after each slides) but I'm currently unable to release as I'm facing the following Stencil issue: https://github.com/ionic-team/stencil/issues/1308

Anyhow I close this issue as it's solve from my side...keep me posted and thx a lot for the feedback 👍

Dellos7 commented 5 years ago

Hello @peterpeterparker, thank you very much!

Just to know, how do you update your own dekdeckgo projects so to use the last release of the starter kit? I mean I was thinking in you know git pull from the remote branch of the starter kit repo, but you might change the index.html and conflicts may appear. Do you use any other technique?

Thank you again, you are super fast!!

peterpeterparker commented 5 years ago

@Dellos7 right now there isn't a super easy straight forward way to do it.

What I do for the deckdeckgo-website is I always install the last libs to reflect the version of the starter kit and then I make manually the js scripts or html changes I would have done in the starter kit (I reflect manually the changes)

At some point I'll probably have to create kind of a library for the js scripts, css and dependencies of the starter kit, that would make things easier

Do that help?

Dellos7 commented 5 years ago

@peterpeterparker this is definitely what I wanted to know. This probably isn't even prioritary as usually you'll write fast the presentations and perform the talk before there's a new deckdeckgo release.

Thanks!

peterpeterparker commented 5 years ago

@Dellos7 cool thx for the feedback and I'm agree with you

of course, some day in the future this could be improved, there is always space for improvement ;)

peterpeterparker commented 5 years ago

@Dellos7 FYI the new version of the starter kit v1.0.0-beta.15 has just been released. this version contains the improvement I mentioned about printing and pagination :)

https://github.com/deckgo/deckdeckgo-starter/blob/master/CHANGELOG.md