search

deckgo / starter-kit

The developer kit to create slides with DeckDeckGo
https://deckdeckgo.com
MIT License
47 stars 13 forks source link

Bundle Ionic for a better offline support #3

Closed peterpeterparker closed 5 years ago

peterpeterparker commented 5 years ago

Right now Ionic (core, css and ionicons) aren't bundled with Webpack, they are still referenced as external scripts in index.html

For a better offline support, these should be bundled with the webpack build

I wasn't able to make it so far but a documentation "how to bundle Ionic core" should be published by Ionic soonish

But if someone knows how to solves, would love to hear from you or even don't hesitate to send me a PR

dimfried commented 5 years ago

did you think about using parcel (https://parceljs.org)? I am not sure if it works fine with ionic, but if it does, it could reduce the overhead of webpack config :)

peterpeterparker commented 5 years ago

@dimfried when it comes to Angular or Ionic often Webpack or Rollup are the bundlers of choice I understood

Furthermore the the PWA support is an important part of the project. Google provide an easy tutorial to pack workbox with Webpack (https://developers.google.com/web/tools/workbox/guides/codelabs/webpack). That's why I picked that bundler for the starter kit.

dimfried commented 5 years ago

fair point, webpack is widely used. if you want I can give this issue a try (though I am not a webpack pro 😅).

peterpeterparker commented 5 years ago

@dimfried thx but not much to do here right now, Ionic will provide soon a "how to bundle Ionic core" documentation, wait & see ;)

dimfried commented 5 years ago

even better! 😃 I will wait then ;)

peterpeterparker commented 5 years ago

I had a look on how to include custom elements because I gonna include the new DeckDeckGo core and end up including Ionic in the bundle

DeckDeckGo offline support is now there :)