deckhouse / deckhouse

Kubernetes platform from Flant
https://deckhouse.io
Other
1.06k stars 111 forks source link

[node-manager] Make lease name for caps controller human-readable #8952

Open unreturned opened 1 month ago

unreturned commented 1 month ago

Preflight Checklist

Use case. Why is this important?

Most of leases in cluster looks like human-readable

~ $ kubectl get leases.coordination.k8s.io -A
NAMESPACE                   NAME                                   HOLDER                                                                            AGE
d8-cert-manager             cert-manager-controller                cert-manager-5cb8cf88d8-twtg9-external-cert-manager-controller                    3d4h
d8-cloud-instance-manager   controller-leader-election-capi        kovalkov-bm-master-3_92764727-4cf1-47fc-b438-4eae4d3bc044                         3d5h
d8-cloud-instance-manager   faf94607.cluster.x-k8s.io              caps-controller-manager-55fd477c45-btp7z_30750f07-0b2b-4946-91b0-529e7fe3e503     3d5h
d8-cni-cilium               cilium-operator-resource-lock          kovalkov-bm-master-2-SztZgCCnLL                                                   3d5h
d8-ingress-nginx            ingress-controller-leader-nginx        controller-nginx-kp4ff                                                            3d4h
d8-ingress-nginx            kruise-manager                         kruise-controller-manager-5fd8578d98-lkg8k_a1b3a4ea-d4f2-4882-9ff2-7601c28cfd69   3d4h
d8-istio                    istio-gateway-deployment-v1x19         istiod-v1x19-86bd86b4bb-ccq4r                                                     3d3h
d8-istio                    istio-operator-lock-v1x19              operator-v1x19-f4f759976-qfz2d_2ddf0bd8-3643-4061-8801-6469449a27fa               3d3h
d8-system                   deckhouse-leader-election              deckhouse-59684bbccc-kblmm.10-128-0-46.d8-system.pod.cluster.local                3d5h
d8-system                   module-docs-builder-t68pt              10-111-4-8.d8-system.pod.cluster.local:8081                                       3d4h
kube-node-lease             kovalkov-bm-frontend-1                 kovalkov-bm-frontend-1                                                            3d5h
kube-node-lease             kovalkov-bm-frontend-2                 kovalkov-bm-frontend-2                                                            3d5h
kube-node-lease             kovalkov-bm-master-1                   kovalkov-bm-master-1                                                              3d5h
kube-node-lease             kovalkov-bm-master-2                   kovalkov-bm-master-2                                                              3d5h
kube-node-lease             kovalkov-bm-master-3                   kovalkov-bm-master-3                                                              3d5h
kube-node-lease             kovalkov-bm-system-1                   kovalkov-bm-system-1                                                              3d5h
kube-node-lease             kovalkov-bm-system-2                   kovalkov-bm-system-2                                                              3d5h
kube-node-lease             kovalkov-bm-worker-1                   kovalkov-bm-worker-1                                                              3d5h
kube-system                 apiserver-dskysqwxhgklvowuwvzdgix4my   apiserver-dskysqwxhgklvowuwvzdgix4my_f7ca032d-cf7b-4b8f-a565-bce6346a4a3b         3d5h
kube-system                 apiserver-mydbdykzgdy6krmidctkbq73yu   apiserver-mydbdykzgdy6krmidctkbq73yu_7a682333-495b-4168-a4b6-6a7c021ddc1f         3d5h
kube-system                 apiserver-snlew5apyool7q7ixo7kkp56ce   apiserver-snlew5apyool7q7ixo7kkp56ce_a4467dee-cada-42b2-87a5-f5b8a258fc8e         3d5h
kube-system                 kube-controller-manager                kovalkov-bm-master-3_486e0296-510b-462a-ab7a-50e8d98f32f2                         3d5h
kube-system                 kube-scheduler                         kovalkov-bm-master-3_babfc75f-bf88-4ee5-b9b3-464797fbf7c1                         3d5h
kube-system                 vpa-admission-controller               vpa-admission-controller-6586459d7-p828j                                          3d4h

And lease used by caps looks foreign

d8-cloud-instance-manager   faf94607.cluster.x-k8s.io              caps-controller-manager-55fd477c45-btp7z_30750f07-0b2b-4946-91b0-529e7fe3e503     3d5h

https://github.com/deckhouse/deckhouse/blob/defe87c0ceeeb4b26349c53fc7ac3c46a222f3c7/modules/040-node-manager/images/caps-controller-manager/src/cmd/main.go#L90

Proposed Solution

Rename it to something like

controller-leader-election-caps

Additional Information

No response

raabdullaev commented 1 month ago

Why is non-human-readable names a problem?

unreturned commented 1 month ago

No technical problem, just a wish to improve the user experience