search

deckhouse / k8s-image-availability-exporter

Alert if an image used in Kubernetes cannot be pulled from container registry
Apache License 2.0
211 stars 25 forks source link

Circumvent insecure secrets listing #138

Closed mowoe closed 5 months ago

mowoe commented 5 months ago

This is a workaround for the issue described in #7 which allows the exporter to run when no secret access is present in the ClusterRole. It just prints a warning about this, but continues to work other than that.

nabokihms commented 5 months ago

@mowoe Thanks, it seems like a valid solution for a workaround. I will review the PR till the end of the day.

Could you please sign your commits using the git commit --ammend --sign-off so satisfy the DCO check?

mowoe commented 5 months ago

Thanks @nabokihms for the lightning fast response, i signed the commits now.

nabokihms commented 5 months ago

@mowoe don't mind chart testing, they should fail 🙂

mowoe commented 5 months ago

@nabokihms should finally be okay now, can you approve the CI runs again? :slightly_smiling_face:

nabokihms commented 5 months ago

@mowoe thanks for the contribution. LGTM!