Closed 2e0byo closed 1 year ago
Unfortunately I need to rebase this against tao: used feature/tao by mistake.
My apologies. I force push my changes a lot. Didn't expect PRs. There would be some work rebasing against tao branch.
abstracts the surfman/glutin gl context creation into a new module gl implements glutin context creation Glutin runs on my machine, although there is still work to do. Surfman still crashes, but compiles.
I've think about this for GTK glarea too. Now you made it happen first. BTW, Glutin works on my machine, while surfman is flicking a lot (see video).
https://i.imgur.com/Qy9X3ih.mp4
I'll rebase this against tao shortly.
Why are you working against my branch instead of emacs-ng repo? What changes need to be upstream to make you workflow smoother? I would do that.
I'm learning rust and feel the use of cfg all over the place here is ugly. I'd appreciate advice on how to tidy it up.
You got me thinking. Maybe we can do something like this
windowing
windowing_impl
like folders
platform
platform_impl
in winit repo ?
This fixes surfman flicking while keeping glutin works too. 0001-fix-surfman.patch.txt
Thanks!
I've not based on this on upstream as the winit/webrender decouple hasn't landed yet. Additionally Tao is probably the way to go over winit, at least on linux, but I could redo the other PR against upstream if more people want to play with that.
Incidentally I get GL errors when opening a new frame, so that's the next thing to dig into on this fussy machine.
folders
Yes, I think something like that is the way to go, with just one cfg()
to include the right file in lib.rs
(since this is a compile-time pick, not runtime).
Unfortunately I need to rebase this against tao: used feature/tao by mistake.
This PR:
gl
Glutin runs on my machine, although there is still work to do. Surfman still crashes, but compiles.
I'll rebase this against tao shortly.
I'm learning rust and feel the use of
cfg
all over the place here is ugly. I'd appreciate advice on how to tidy it up.