search

declarativesystems / onceover-codequality

Lint and syntax validation for onceover
Apache License 2.0
3 stars 7 forks source link

puppet-lint renamed to puppetlabs-puppet-lint #30

Closed ChrLau closed 1 year ago

ChrLau commented 1 year ago

Hi, with https://github.com/puppetlabs/puppet-lint/pull/158 the puppet-lint Gem has been renamed to puppetlabs-puppet-lint. And now we are getting all sorts of warnings in our CI-Pipeline when we run the linting check with onceover run codequality --no_docs --no_puppetfile --no_syntax.

The warnings are the same as those mentioned in https://github.com/puppetlabs/puppet-lint/issues/169. There it's stated that this is happening when puppet-lint and puppetlabs-puppet-lint are used at the same time.

Are you able to update your dependencies to puppetlabs-puppet-lint?

Thanks!

GeoffWilliams commented 1 year ago

fix released in 0.11.0

ChrLau commented 1 year ago

Thanks @GeoffWilliams !

alexjfisher commented 1 year ago

and now I have both puppet-lint, (because almost all lint plugins depend on the original gem!), and puppetlabs-puppet-lint installed into my builds, and this is not good...

alexjfisher commented 1 year ago

Also keep an eye out for the name of the binary changing... https://github.com/puppetlabs/puppet-lint/pull/170/files#diff-f285faa44ba3d78ef73a0305522f63837a0e68799489cfb2bb66b72a431db86c

ChrLau commented 1 year ago

@alexjfisher Yes, the current situation is rather ugly. Especially since the new puppetlabs-puppet-lint still produces many warnings.. See https://github.com/puppetlabs/puppet-lint/issues/169

From this perspective I could understand if you define the dependencies in a way that only the puppet-lint versions are used before it got renamed.. Which of course doesn't help if you have other gems/dependencies who don't do that..

I just can't understand why they were in such a hurry to rename that Gem without proper testing..