search

declension / squeeze-alexa

Squeezebox integration for Amazon Alexa
GNU General Public License v3.0
59 stars 20 forks source link

Add french translation #66

Closed chatainsim closed 6 years ago

chatainsim commented 6 years ago

Add french translation

declension commented 6 years ago

Thanks @chatainsim - this is great. Something's gone a bit wrong with the translation process though - there's no English (all the msgids should have English and msgstr French), so nothing will be registered.

If you look at the German translation it should be clearer what's necessary, or you can use something like Poedit.

Note that we're soon supporting Intents v1 (see #23, and #61) which will support translations for slots like the genres, playlists, player names etc.

chatainsim commented 6 years ago

Soory @declension , I was too quick. I've corrected the file. Tell me if it's ok now.

I'll take a look at what is Intents v2

declension commented 6 years ago

Great, looks perfect (but haven't tried it yet - have you tested it with your own skill?). At some point I'll add some automated tests for new (and existing) translations to catch these types of things at PR time.

(Oh and sorry I got the wrong link, I meant intents v1... I always forget - they started at v0 :smile: )

declension commented 6 years ago

Thanks @chatainsim !

declension commented 6 years ago

Note that this only means output from squeeze-alexa is in French. The utterances still need translating to support speaking to squeeze-alexa in French - that's what utterances.txt is for (see German example) or the new v1 intent schema is for.

I'll update the CONTRIBUTING as it still doesn't mention all this...

chatainsim commented 6 years ago

I haven't tested it yet. I think I'll translate the utterences first.

declension commented 6 years ago

Great. It's working fine - I added a test in 53860cdd that probes the French translation and it's coming out correctly :+1:

chatainsim commented 6 years ago

Nice, thanks