Rethink Caching & fix MQTT connections

declension / squeeze-alexa

Squeezebox integration for Amazon Alexa

GNU General Public License v3.0

59 stars 20 forks source link

Rethink Caching & fix MQTT connections #88

Closed declension closed 5 years ago

declension commented 5 years ago

Rewrite caching layer, wasn't working: use normal factories for Server and Factory, not metaclass stuff
Add explicit start() and stop() methods to Transport.
Keep track of connected state across Transport and Server (and link the two)
Listen to disconnect signals and recreate connection if dropped (MQTT)
Better logging of re-use of server stuff
Massive speedup: 2450ms -> 430ms average (> 600% faster) :smile:

This fixes #87

crmbls commented 5 years ago

Some testing in practise has shown that I unfortunately cannot reproduce that #88 changes fix the #52 bug at least in my environment (as mentioned in release-notes for v2.2).

declension commented 5 years ago

@crmbls - thanks for re-testing.

I'd hoped that would be an improvement though :disappointed:
I'll leave #52 open then. If you have any more details or steps to replicate please add them there.