Cancel Complete fixes - Githubissues

decline-cookies / anvil-unity-dots

Unity DOTS and ECS specific additions and extensions to Anvil

MIT License

4 stars 1 forks source link

Cancel Complete fixes #157

Closed jkeon closed 1 year ago

jkeon commented 1 year ago

Cancel Completes used to just return Entity instances but that made it difficult to merge into generic jobs that also took in IEntityProxyInstance.

To make the API easier to work with, there is a CancelCompleted struct that is an IEntityProxyInstance that is returned now instead.

What issues does this resolve?

None

What PRs does this depend on?

None

Does this introduce a breaking change?

[x] Yes - Change all Cancel Complete jobs to take in CancelCompleted instead of just Entity
[ ] No

jkeon commented 1 year ago

Updated for you to try.

You can now call taskDriver.ConfigureDriverJobWhenCancelComplete and the job type is ITaskJobForDefer<CancelComplete>

Tag Alongs

Fixed a pretty serious access bug in acquiring readers and writers outside the Task System