decline-cookies / anvil-unity-dots

Unity DOTS and ECS specific additions and extensions to Anvil
MIT License
4 stars 1 forks source link

AbstractJobConfig - Log and Attempt to resolve duplicate requires #189

Closed mbaker3 closed 1 year ago

mbaker3 commented 1 year ago

Implement a less disruptive outcome if multiple requires of the same type are set on a job config.

This improves the developer experience by allowing developers to continue their test and fix the configuration error later.

What is the current behaviour?

The job config will throw an exception any time a duplicate require is identified.

What is the new behaviour?

In situations where duplicate requires occur the config now logs an error describing the issue but then attempts to accommodate the request and continue execution.

What issues does this resolve?

What PRs does this depend on?

Does this introduce a breaking change?

mbaker3 commented 1 year ago

Snuck in a commit that removes the logged error when ANY duplicate require resolution happens. That logged error doesn't make sense in the usage context anymore. Particularly now that we're adopting the JobPart pattern.