Closed mbaker3 closed 1 year ago
RemoveSwapBack was taking in a readonly reference (in) which was making a local copy rather than modifying the collection as intended.
RemoveSwapBack
in
Calling RemoveSwapBack will do the work but on a copy of the collection so the caller won't actually receive the change.
RemoveSwapBack correctly modifies the original collection by receiving a ref reference.
ref
RemoveSwapBackwas taking in a readonly reference (in) which was making a local copy rather than modifying the collection as intended.What is the current behaviour?
Calling
RemoveSwapBackwill do the work but on a copy of the collection so the caller won't actually receive the change.What is the new behaviour?
RemoveSwapBackcorrectly modifies the original collection by receiving arefreference.What issues does this resolve?
What PRs does this depend on?
Does this introduce a breaking change?