Remove the temp entity from being returned when IEntitySpawnDefinitionExtension methods are called.
Returning the temp entity encourages a pattern that restricts the utility of a definition. The better approach is to have the definition add itself to the entity/component that you want to have reference to the new entity.
What is the current behaviour?
A temp entity is returned when the methods are called.
What is the new behaviour?
No entity is returned when the methods are called.
What issues does this resolve?
None
What PRs does this depend on?
None
Does this introduce a breaking change?
[x] Yes
[ ] No
Have your definitions add itself to the entity/component that you want to have reference to the new entity.
Remove the temp entity from being returned when
IEntitySpawnDefinitionExtensionmethods are called.Returning the temp entity encourages a pattern that restricts the utility of a definition. The better approach is to have the definition add itself to the entity/component that you want to have reference to the new entity.
What is the current behaviour?
A temp entity is returned when the methods are called.
What is the new behaviour?
No entity is returned when the methods are called.
What issues does this resolve?
What PRs does this depend on?
Does this introduce a breaking change?
Have your definitions add itself to the entity/component that you want to have reference to the new entity.