Task Driver Clean Up - Githubissues

decline-cookies / anvil-unity-dots

Unity DOTS and ECS specific additions and extensions to Anvil

MIT License

4 stars 1 forks source link

Task Driver Clean Up #235

Closed jkeon closed 1 year ago

jkeon commented 1 year ago

Changing public methods to protected and exposing CancelRequest and CancelComplete streams publicly as outlined in #196

What is the current behaviour?

Less than ideal setup which results in more code, special paths, and a less consistent pattern for developers to learn and use.

What is the new behaviour?

Less code!
More consistency
Stronger alignment with what you are scheduling jobs on.
Public facing IDriverCancelRequestDataStream and ISystemCancelRequestDataStream
- It would be good to get rid of these eventually and make the CancelRequest be a IEntityProxyDataInstance just like CancelComplete

What issues does this resolve?

Resolves #196

What PRs does this depend on?

None

Does this introduce a breaking change?

[x] Yes - API changes. Pretty easy to migrate though.
[ ] No