search

deco-sites / fashion

The deco.cx Fashion Store Starter
https://fashion.deco.site
76 stars 126 forks source link

feat: multiplatform #440

Closed tlgimenes closed 1 year ago

tlgimenes commented 1 year ago

What is this contribution about?

This PR makes fashion template multi platform

How to test it?

Change site.json to staging account and test the /gim page. Also, don't forget to change the platform on platform.ts

Extra info

This PR should be used alongside this PR: https://github.com/deco-sites/std/pull/193

igorbrasileiro commented 1 year ago

Great job, this solves the problem related to one store with multiple platforms.

This seems not be scalable and the code will be messed up when we have 10 platforms. Does it make sense?

tlgimenes commented 1 year ago

Great job, this solves the problem related to one store with multiple platforms.

This seems not be scalable and the code will be messed up when we have 10 platforms. Does it make sense?

Yes, I'm not happy with this final format. Let's migrate to apps so we can have more info in refactoring fashion