post-mount is broken by amtm 4.2

decoderman / amtm

amtm - the Asuswrt-Merlin Terminal Menu

https://diversion.ch/amtm.html

GNU General Public License v3.0

175 stars 12 forks source link

post-mount is broken by amtm 4.2 #19

Closed Max33Verstappen closed 8 months ago

Max33Verstappen commented 8 months ago

The "post-mount" is broken because of . /jffs/addons/amtm/mount-entware.mod # Added by amtm added but "mount-entware.mod" not there and never getting downloaded, hence the execution interrupted.
The "post-mount" gets modified every time "amtm" is executed as sed -i '/^[[:space:]]*$/d' "$1" in t_f /jffs/scripts/post-mount is applied on "post-mount", so the timestamp of the file keeps changing even no actual content is changed. And removing blank lines without prompting is inappropriate as users may keep blank lines on purpose.

decoderman commented 8 months ago

Thanks for reporting. I can verify your findings, the extra test I built in in v4.2 is overzealous and overshoots its intended purpose. Will be fixed ASAP.

Max33Verstappen commented 8 months ago

The updates fixed the problems, but t_f /jffs/scripts/post-mount is still invoked when adding . /jffs/addons/amtm/mount-entware.mod # Added by amtm to the "post-mount", which means all the blank lines are wiped out during that process. Is that intentional?

decoderman commented 8 months ago

Yes and no. I‘ll explain when I actually fix the real underlaying problem. This was just a hotfix to prevent further issues users may have. Stand by, I’ll get after it ASAP.

Max33Verstappen commented 8 months ago

Sure. Not a big issue. The hotfix is relatively important as it'd prevent the entware from being mounted if users reboot the device and get confused somewhat.