search

decoderman / amtm

amtm - the Asuswrt-Merlin Terminal Menu
https://diversion.ch/amtm.html
GNU General Public License v3.0
175 stars 12 forks source link

Email module: curl sends the wrong EHLO string #22

Closed tazio closed 6 months ago

tazio commented 7 months ago

Currently, in the EHLO command starting the SMTP connection it is appended the filename. This causes any MTA to reject the connection if EHLO restrictions are in place, with error 504.

The problem is in this line: https://github.com/decoderman/amtm/blob/b1623e8bdb337b2f4b56e64b9e150c8d3e98c15e/amtm_modules/email.mod#L285

It should be fixed with something like: /usr/sbin/curl -v --url $PROTOCOL://$SMTP:$PORT/$SMTP The server fqdn would be used by curl in the EHLO command, correctly.

decoderman commented 6 months ago

Hi @tazio Thank you for your input and correction. It will be included in the next amtm release.

decoderman commented 6 months ago

Progress update: I released Diversion 5.1.1 patch update yesterday and included your modification. Next is amtm which I'm working on at the moment.

decoderman commented 6 months ago

With the release of amtm 4.4 just now this request is completed.