decompals / ido-static-recomp

IDO static recomp
43 stars 10 forks source link

Fix UB on `wrapper_memcpy` #27

Closed AngheloAlf closed 2 years ago

AngheloAlf commented 2 years ago

IRIX's memcpy seems to allow overlapping pointers, while host's memcpy usually rely on both pointers parameters non overlapping (UB otherwise), to avoid this wrapper_memcpy was changed to not actually use memcpy and do a manual copy instead. We want to believe this should fix the ghost-bug which has been affecting random people while building OoT.

Kinda unrelated changes: